Evaluation — Leave Requests (Django + Templates)

Stack: Django + Django Templates (HTML/CSS/JS)

Evaluator: ___________

Submission Date: ___________

Pass Threshold: 90%

How to Mark

[✓] Fully correct
[~] Partial — note the gap below the item
[✗] Missing or wrong

1. Django — `LeaveRequest` Model

workspace FK → Workspace, ON DELETE CASCADE, related_name='leave_requests'
employee FK → settings.AUTH_USER_MODEL, ON DELETE CASCADE, related_name='leave_requests'
leave_type CharField using LeaveType TextChoices: annual, sick, personal, unpaid
start_date DateField
end_date DateField
total_days PositiveIntegerField
reason TextField, blank=True, default=''
status CharField using Status TextChoices: submitted, approved, rejected, cancelled; default=submitted
reviewed_by FK → AUTH_USER_MODEL, null=True, blank=True, ON DELETE SET_NULL, related_name='reviewed_leaves'
reviewed_at DateTimeField, null=True, blank=True
review_notes TextField, blank=True, default=''
created_at DateTimeField, auto_now_add=True
Meta ordering: ['-created_at']
CheckConstraint: end_date >= start_date
CheckConstraint: total_days > 0
Composite index on (workspace, employee, status)
Composite index on (workspace, status, -created_at)
Migration generated and committed

2. Django — `LeaveRequestForm`

Form extends forms.ModelForm
Meta model = LeaveRequest
Meta fields = ['leave_type', 'start_date', 'end_date', 'reason']
start_date widget: forms.DateInput(attrs={'type': 'date'})
end_date widget: forms.DateInput(attrs={'type': 'date'})
clean_start_date(): raises ValidationError if start_date < today
clean(): raises ValidationError on end_date field if end_date < start_date
No business logic (overlap check) in form — that belongs in LeaveService

3. Django — `LeaveService`

submit_request(workspace, employee, leave_type, start_date, end_date, reason='') method
submit_request: validates start_date ≥ today
submit_request: validates end_date ≥ start_date
submit_request: computes total_days = (end_date - start_date).days + 1
submit_request: overlap check — queries for existing submitted/approved requests for the same employee that overlap the requested dates — raises ValidationError if found
approve_request(leave_request, reviewed_by, review_notes='') method
approve_request: raises ValidationError if status != 'submitted'
approve_request: sets status='approved', reviewed_by, reviewed_at=now()
reject_request(leave_request, reviewed_by, review_notes) method
reject_request: review_notes required — raises ValidationError if blank
reject_request: raises ValidationError if status != 'submitted'
reject_request: sets status='rejected', reviewed_by, reviewed_at, review_notes
cancel_request(leave_request, actor) method
cancel_request: raises PermissionDenied if actor != leave_request.employee
cancel_request: raises ValidationError if status != 'submitted'
cancel_request: sets status='cancelled'
All methods are @staticmethod

4. Django — `WorkspaceMemberMixin`

Mixin defined and used on all 5 views
dispatch() sets self.workspace using get_object_or_404(Workspace, id=kwargs['workspace_id'])
dispatch() sets self.membership using get_object_or_404(WorkspaceMember, ...)
Extends LoginRequiredMixin

5. Django — Views

MyLeavesView at GET /workspace/{id}/my-leaves/
Returns only request.user's leave requests — not all workspace leaves
Supports ?status= filter — applied in DB queryset
Paginated: 10 per page
Template: my_leaves.html
SubmitLeaveView at GET+POST /workspace/{id}/my-leaves/submit/
GET: renders empty LeaveRequestForm
POST: validates form → calls LeaveService.submit_request() → redirects to my-leaves (POST→redirect→GET)
Template: submit_form.html
CancelLeaveView at POST /workspace/{id}/my-leaves/{leave_id}/cancel/
POST only (no GET handler)
Calls LeaveService.cancel_request() with actor=request.user
Redirects to my-leaves on success with success message
On error: redirects with error message (does not raise 500)
AdminLeavesView at GET /workspace/{id}/admin/leaves/
Returns 403 if caller is not admin/owner role — does NOT show an empty list to members
Returns all workspace leave requests — not just caller's
Supports ?status= and ?employee_id= filters
Paginated: 20 per page
Template: admin_leaves.html
ApproveLeaveView at POST /workspace/{id}/admin/leaves/{leave_id}/approve/
403 for non-admin/owner
Calls LeaveService.approve_request()
Redirects to admin-leaves with success message
RejectLeaveView at POST /workspace/{id}/admin/leaves/{leave_id}/reject/
403 for non-admin/owner
review_notes from POST body — shows error if blank
Calls LeaveService.reject_request()
Redirects to admin-leaves with success/error message

6. Django — URL Configuration

All 6 URL patterns defined
URL names use kebab-case: my-leaves, submit-leave, cancel-leave, admin-leaves, approve-leave, reject-leave
workspace_id captured as <int:workspace_id>
leave_id captured as <int:leave_id>

7. Templates

General — all templates:

All templates extend base.html
All templates use {% load static %} at the top
No <style> blocks in any template
No <script> blocks with logic in any template
CSS linked via {% static 'css/leaves.css' %}
JS linked via {% static 'js/leaves.js' %}

my_leaves.html:

Status filter form uses GET method
Leave requests table rendered
Status badge uses correct CSS class per status (.badge-submitted, .badge-approved, etc.)
Cancel button is a POST form with {% csrf_token %}
Cancel form uses confirmation via data-* attributes (not inline JavaScript in template)
Pagination links rendered

submit_form.html:

Each form field rendered individually (not {{ form.as_p }})
Field errors shown below each field using {{ form.field_name.errors }}
Non-field errors shown at top of form
Submit button has loading state attributes via data-*
{% csrf_token %} present

admin_leaves.html:

Filter form uses GET method
All requests table: Employee | Leave Type | Dates | Days | Status | Actions columns
Approve: POST form button with {% csrf_token %}
Reject: POST form with hidden input for review_notes — inline form shown via JS class toggle
Pagination links

8. CSS — `static/css/leaves.css`

.badge-submitted defined with blue background (or uses --color-* variable)
.badge-approved defined with green background
.badge-rejected defined with red background
.badge-cancelled defined with grey background
CSS uses custom properties: --color-success, --color-danger, etc.
Table stripe/hover styles defined
Form field layout: label above field, error below
Filter bar styles defined
Pagination styles defined
Responsive: table scrolls horizontally on mobile (overflow-x: auto or equivalent)
No hardcoded hex colors in HTML — all in CSS

9. JS — `static/js/leaves.js`

Cancel confirmation uses data-leave-type and data-form-id attributes — not string interpolation in JS
document.querySelectorAll('.btn-cancel-leave') used to attach event listeners
confirm() dialog message uses btn.dataset.leaveType — reads from DOM attribute
document.getElementById(btn.dataset.formId).submit() used to submit the hidden form
Reject inline form: clicking "Reject" shows a hidden <div> containing the reason textarea
Show/hide done by toggling a CSS class (e.g. .is-visible) — not element.style.display manipulation
Rejection reason passed as a hidden <input> inside the reject POST form

10. Standards Compliance

Business logic (overlap check, status validation) entirely in LeaveService — none in views
All POST views use POST→redirect→GET pattern (no re-rendering the form on success)
Django messages framework used for success/error messages after redirect
No inline styles in templates
No inline scripts in templates
CSRF token present on every POST form
Admin views return 403 (not 404 or empty list) for unauthorized access
Cancel prevents actor ≠ employee (enforced in service, not just template hide)

Score Summary

Section	Total Items	✓ Pass	~ Partial	✗ Fail
1. Model	17
2. Form	8
3. Service	16
4. Mixin	4
5. Views	19
6. URL Config	6
7. Templates	21
8. CSS	10
9. JS	7
10. Standards	8
Total	116

Score: ___ / 116 (___%) — Pass / Conditional / Fail

Evaluator Notes

_Record specific failures, partial items, or other observations here._